Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added New Env variable for Unpublished queries #7236

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

adithyapathipaka
Copy link

What type of PR is this?

  • Refactor
  • Feature
  • Bug Fix
  • New Query Runner (Data Source)
  • New Alert Destination
  • Other

Description

Added new Env Variable REDASH_FEATURE_VIEW_UNPUBLISH_QUERIES and updated include_drafts param to get value from REDASH_FEATURE_VIEW_UNPUBLISH_QUERIES

  1. Application shows all the unpublished queries from other users on the UI by default, which is due to Hard coded value with True for the include_draft param.
  2. Added new Env Variable REDASH_FEATURE_VIEW_UNPUBLISH_QUERIES (boolean) through which application can be configured to view unpublished queries
  3. By Default REDASH_FEATURE_VIEW_UNPUBLISH_QUERIES will be true and can be configure through to false by adding the variable to env file.

How is this tested?

  • Unit tests (pytest, jest)
  • E2E Tests (Cypress)
  • Manually
  • N/A

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants