Add CC Zero to the cc_license_mark macro #668
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In getpelican#530 is reported that the cc_license_mark macro, written in templates/includes/cc-license.html, doesn't get the correct url and image when CC_LICENSE is set to "zero" or "cc0". That's because the format of the url is different. This change add an if to know if it is a CC Public Domain (Zero) mark before to set the license.
Write documentation for the new feature of the macro that shows the license according to what is set in CC_LICENSE.
ivanhercaz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #530 @josch reported that the
cc_license_markmacro, written intemplates/includes/cc-license.html, doesn't get the correct url and image whenCC_LICENSEis set to "zero" or "cc0". That's because the format of the url is different. This change add an if to know if it is a CC Public Domain (Zero) mark before to set the license.I tested and this works for me, the old code to set the licenses and the current code to set the public domain mark.