Support default image answers #3579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seadowg
requested changes
Jan 13, 2020
collect_app/src/androidTest/java/org/odk/collect/android/formentry/DefaultImageAnswerTest.java
Show resolved
Hide resolved
lognaturel
reviewed
Jan 31, 2020
collect_app/src/main/java/org/odk/collect/android/widgets/BaseImageWidget.java
Outdated
Show resolved
Hide resolved
lognaturel
reviewed
Jan 31, 2020
collect_app/src/main/java/org/odk/collect/android/widgets/BaseImageWidget.java
Outdated
Show resolved
Hide resolved
grzesiek2010
force-pushed
the
COLLECT-84
branch
from
98dff8f to
8133db6
Compare
lognaturel
reviewed
Feb 6, 2020
collect_app/src/main/java/org/odk/collect/android/widgets/BaseImageWidget.java
Show resolved
Hide resolved
collect_app/src/androidTest/java/org/odk/collect/android/formentry/DefaultImageAnswerTest.java
Show resolved
Hide resolved
|
Tested with success: When I was testing, I have recognized separate issues: @opendatakit-bot unlabel "needs testing" |
seadowg
approved these changes
Feb 12, 2020
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #84
What has been done to verify that this works as intended?
I tested the implemented changes manually and added an espresso tests.
Why is this the best possible solution? Were any other approaches considered?
It's the only solution we agreed in #84 and https://forum.opendatakit.org/t/proposal-specify-a-fixed-image-to-be-annotated-or-signed/14954. I can't come up with anything simpler or better.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
This change is only related to Image widgets so we can test only those. It just allows to use default image values. I don't find this change very risky so testing the attached form should be enough.
Do we need any specific form for testing your changes? If so, please attach one.
defaultImage.zip
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew checkAlland confirmed all checks still pass OR confirm CircleCI build passes and run./gradlew connectedDebugAndroidTestlocally.