Content-Security-Policy: allow images from data: URLs #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QR displayed in odk-central-frontend are displayed with src=data:... Closes getodk#629
|
Tagging @lognaturel, since I think she reviewed the original CSP. |
lognaturel
approved these changes
Nov 11, 2024
|
Changed the base to |
I think it would be helpful to add this as a comment, but commenting every one of these rules would get out of hand quite quickly 🤔 |
|
I think what you've done with the commit message is great! If we have questions we can use git to see what was going on. I always try to leave a note of what I think about when I do a review also for archaeology purposes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QR displayed in odk-central-frontend are displayed with src=data:...
Closes #629