Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make two submission filters multiselect #645

Merged
merged 9 commits into from
Nov 29, 2022
Merged

Make two submission filters multiselect #645

merged 9 commits into from
Nov 29, 2022

Conversation

matthew-white
Copy link
Member

@matthew-white matthew-white commented Nov 15, 2022 •
edited
Loading

Closes #559 and closes #396.

@matthew-white
Copy link
Member Author

matthew-white commented Nov 15, 2022 •
edited
Loading

Currently, this sequence is possible with the submitter and review state filters:

  • All options are selected.
  • Select none.
  • Close the dropdown.
  • "None" falls back to "all" for the update:modelValue event. ✅
  • But if you open the dropdown again, it's still the case that all checkboxes are unchecked. ❌

@matthew-white matthew-white linked an issue Nov 16, 2022 that may be closed by this pull request
Make review state filter a multiselect #559
Closed
matthew-white
matthew-white commented Nov 16, 2022
View reviewed changes
Copy link
Member Author

@matthew-white matthew-white left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notes from interactive code review

src/components/submission/filters/review-state.vue Show resolved Hide resolved
src/components/submission/filters/submitter.vue Outdated Show resolved Hide resolved
src/util/router.js Show resolved Hide resolved
src/util/router.js Outdated Show resolved Hide resolved
src/util/router.js Show resolved Hide resolved
src/components/submission/list.vue Show resolved Hide resolved
matthew-white
matthew-white commented Nov 23, 2022
View reviewed changes
Copy link
Member Author

@matthew-white matthew-white left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interactive code review with @ktuite

src/components/submission/filters/submitter.vue Outdated Show resolved Hide resolved
src/components/multiselect.vue Outdated Show resolved Hide resolved
src/components/multiselect.vue Outdated Show resolved Hide resolved
src/components/multiselect.vue Outdated Show resolved Hide resolved
src/components/multiselect.vue Outdated Show resolved Hide resolved
src/components/multiselect.vue Outdated Show resolved Hide resolved
src/components/multiselect.vue Outdated Show resolved Hide resolved
ktuite
ktuite approved these changes Nov 23, 2022
View reviewed changes
Copy link
Member

@ktuite ktuite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just finished an interactive review with Matt - will review tests after thanksgiving!

@matthew-white
Copy link
Member Author

@ktuite and I just reviewed 793aae1 interactively. @ktuite will take a look at tests asynchronously.

@matthew-white
Copy link
Member Author

I've noticed an issue here, which I've filed at #664. I think we can come back to that later.

@matthew-white matthew-white merged commit 0d30a71 into master Nov 29, 2022
@matthew-white matthew-white deleted the multiselect branch November 29, 2022 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktuite ktuite ktuite approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make review state filter a multiselect Show warning if user selects 100+ columns
2 participants
@matthew-white @ktuite