bug(e2e): flaky assertion in beforeEach #1851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keellyp
approved these changes
Nov 5, 2024
ansmonjol
force-pushed
the
flaky-assert
branch
from
dfc98ce
to
26d974a
Compare
ansmonjol
force-pushed
the
flaky-assert
branch
from
26d974a
to
c7097b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We have an assertion that make the last e2e test fail randomly
Description
Try to simplify the assertion. It not have the correct type applied and those attributes are mandatory.
Also removed the
::preventLogincheck in the title. That's a good idea but it's not used in the app