feat: Cascade parent plan changes #1818
Open
+134
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansmonjol
approved these changes
Oct 22, 2024
stephenlago99
force-pushed
the
feat-cascade-parent-plan-changes
branch
2 times, most recently
from
ae782a8
to
8e96d8e
Compare
ansmonjol
force-pushed
the
feat-cascade-parent-plan-changes
branch
from
3398a27
to
d92cf56
Compare
stephenlago99
force-pushed
the
feat-cascade-parent-plan-changes
branch
2 times, most recently
from
ae0abfd
to
cb01372
Compare
stephenlago99
force-pushed
the
feat-cascade-parent-plan-changes
branch
from
cb01372
to
5a78252
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR implements a new modal that is shown when trying to edit a plan that has some overrides (subscriptions that have different values for the plan).
The changes were done based on the frontend dive-in:
[FE] [Dive-in] Cascade parent plan changes to child plan.Description
👉 Implemented a new dialog -
ImpactOverridenSubscriptionsDialogThe dialog has it's own Formik form in order to keep values separated (the user could have updated the values, then closed the modal which would have left that value in a floating state). This pattern can also be seen in the existing CreateWebhookDialog component.
👉 When saving a plan, check for plan.hasOverriddenPlans
If it is true, we show the new modal, and when the user presses Save in the new modal, we populate the value in formik and we send it to the
updatePlanmutation.Implements LAGO-457