Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance: dokan plugin header logo banner icon enhancement #2513

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

osmansufy
Copy link
Contributor

@osmansufy osmansufy commented Jan 13, 2025

All Submissions:

  • My code follow the WordPress' coding standards
  • My code satisfies feature requirements
  • My code is tested
  • My code passes the PHPCS tests
  • My code has proper inline documentation
  • I've included related pull request(s) (optional)
  • I've included developer documentation (optional)
  • I've added proper labels to this pull request

Changes proposed in this Pull Request:

Related Pull Request(s)

  • Full PR Link

Closes

How to test the changes in this Pull Request:

  • Steps or issue link

Changelog entry

Title

update: Upgrade banner remove

Detailed Description of the pull request. What was previous behaviour
and what will be changed in this PR.

Before Changes

Describe the issue before changes with screenshots(s).

After Changes

Describe the issue after changes with screenshot(s).

Feature Video (optional)

Link of detailed video if this PR is for a feature.

PR Self Review Checklist:

  • Code is not following code style guidelines
  • Bad naming: make sure you would understand your code if you read it a few months from now.
  • KISS: Keep it simple, Sweetie (not stupid!).
  • DRY: Don't Repeat Yourself.
  • Code that is not readable: too many nested 'if's are a bad sign.
  • Performance issues
  • Complicated constructions that need refactoring or comments: code should almost always be self-explanatory.
  • Grammar errors.

FOR PR REVIEWER ONLY:

As a reviewer, your feedback should be focused on the idea, not the person. Seek to understand, be respectful, and focus on constructive dialog.

As a contributor, your responsibility is to learn from suggestions and iterate your pull request should it be needed based on feedback. Seek to collaborate and produce the best possible contribution to the greater whole.

  • Correct — Does the change do what it’s supposed to? ie: code 100% fulfilling the requirements?
  • Secure — Would a nefarious party find some way to exploit this change? ie: everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities?
  • Readable — Will your future self be able to understand this change months down the road?
  • Elegant — Does the change fit aesthetically within the overall style and architecture?

Summary by CodeRabbit

Summary by CodeRabbit

  • Style Updates

    • Updated version tag styling with refined font sizes, colors, and layout
    • Modified admin menu logo background size
    • Adjusted SVG icon dimensions for Pro badge
  • UI Changes

    • Removed UpgradeBanner component from multiple admin pages (Dashboard, Help, Settings, Vendors, Withdraw, ChangeLog)
  • Visual Refinements

    • Updated admin notice and dropdown menu styling
    • Refined admin header icon dimensions
    • Adjusted dropdown menu positioning and box-shadow effects

@osmansufy osmansufy self-assigned this Jan 13, 2025

This comment was marked as off-topic.

coderabbitai[bot]

This comment was marked as off-topic.

@osmansufy osmansufy requested a review from mrabbani January 13, 2025 08:49
@osmansufy osmansufy added the Needs: Dev Review It requires a developer review and approval label Jan 13, 2025
Copy link
Member

@mrabbani mrabbani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@getdokan/product, Pls inform Tareq vai and @getdokan/marketing about the Upgrade banner removal.

includes/Admin/Menu.php Outdated Show resolved Hide resolved
@mrabbani mrabbani added Needs: Author Reply and removed Needs: Dev Review It requires a developer review and approval labels Jan 15, 2025
@jamil-mahmud
Copy link

@getdokan/product, Pls inform Tareq vai and @getdokan/marketing about the Upgrade banner removal.

@mrabbani vai,
I have shared my concern to Tareq vai and Marketing Team as well. Marketing Team is having a discussion on this banner. Once I get the outcome of that discussion I will let you know here

cc: @osmansufy vai

Copy link
Member

@mrabbani mrabbani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamil-mahmud vai confirmed that it is cleared from the @getdokan/marketing team.

@mrabbani mrabbani added Needs: Testing This requires further testing 👍 Dev Review Done and removed Needs: Author Reply labels Jan 21, 2025
@shashwatahalder01
Copy link
Contributor

@osmansufy Bhai, could you kindly share a screenshot showcasing the visual changes introduced by this PR?

@osmansufy
Copy link
Contributor Author

@osmansufy Bhai, could you kindly share a screenshot showcasing the visual changes introduced by this PR?

@shashwatahalder01 bhai,
You can check this issue task mentioned by @jamil-mahmud bhai
https://github.com/getdokan/dokan-pro/issues/4023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Testing This requires further testing 👍 Dev Review Done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants