fix: Dokan admin analytics script build stuff. #2419
Conversation
WalkthroughThe changes involve modifications to the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
MdAsifHossainNadim
added
Needs: Testing
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
webpack.config.js (1)
43-43: Consider adding a comment describing the entry point's purpose.For better maintainability, consider adding a brief comment above the entry point describing its purpose, similar to how "Dokan tailwind css" is documented.
+ // Admin analytics dashboard scripts 'dokan-admin-analytics': './assets/src/js/dokan-admin-analytics.js',includes/Assets.php (1)
561-563: LGTM! Consider optimizing script loading.The script registration looks good with proper dependencies and version handling. However, consider conditionally loading the analytics script only on relevant admin pages to optimize performance.
Consider wrapping the analytics script enqueue with a page-specific check:
- wp_enqueue_script( 'dokan-admin-analytics' ); + if ( isset( $wp->query_vars['analytics'] ) || apply_filters( 'dokan_should_load_admin_analytics', false ) ) { + wp_enqueue_script( 'dokan-admin-analytics' ); + }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
- includes/Assets.php (1 hunks)
- webpack.config.js (1 hunks)
🔇 Additional comments (1)
webpack.config.js (1)
43-43: LGTM! Verify source file existence.The new entry point follows the project's established patterns for admin-related scripts.
Let's verify the source file exists and there are no duplicate entries:
✅ Verification successful
✓ Entry point and source file verified
The source file exists at the correct location and there are no duplicate entries in the webpack configuration. The implementation follows the project's established patterns.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Verify the source file exists fd "dokan-admin-analytics.js" "assets/src/js" # Check for potential duplicate entries of this script rg -i "dokan.?admin.?analytics" -g "webpack.config.js"Length of output: 226
MdAsifHossainNadim
changed the title
All Submissions:
Changes proposed in this Pull Request:
Related Pull Request(s)
Closes
How to test the changes in this Pull Request:
Changelog entry
Title
Detailed Description of the pull request. What was previous behaviour
and what will be changed in this PR.
Before Changes
Describe the issue before changes with screenshots(s).
After Changes
Describe the issue after changes with screenshot(s).
Feature Video (optional)
Link of detailed video if this PR is for a feature.
PR Self Review Checklist:
FOR PR REVIEWER ONLY:
Summary by CodeRabbit
New Features
dokan-admin-analyticsscript to improve organization.Improvements
Bug Fixes