Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Ditto SDK dependency to 4.8.3 #170

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bplattenburg
Copy link
Member

@bplattenburg bplattenburg commented Jan 2, 2025

Updates the Ditto SDK minimum version to 4.8.3 to avoid the iOS 18 crash.

@bplattenburg bplattenburg requested a review from a team as a code owner January 2, 2025 17:42
@bplattenburg
Copy link
Member Author

Given this is a breaking change, I'm going to hold merging this until other outstanding work makes it in

@bplattenburg bplattenburg changed the title Update Ditto SDK dependency to 4.9.1 Update Ditto SDK dependency to 4.8.3 Jan 7, 2025
@bplattenburg
Copy link
Member Author

bplattenburg commented Jan 7, 2025

I've gone back and forth on 4.8.3 vs 4.9.1 here and could use some other thoughts. Both versions include the Ditto SDK crash fix for iOS 18, and the tradeoff is 4.8.3 lets a broader range of SDK users leverage tools, while 4.9.1 also includes a fix for a memory leak in the DiskUsage code underlying the DittoDiskUsage tool.

@rdas-ditto
Copy link
Contributor

I propose we always build tools on the latest SDK (e.g., 4.9.1) to include the newest fixes and features. For users needing older versions, we can tag tools with SDK releases (e.g., v4.8.3-tools). This approach keeps us current while providing access to legacy-compatible tools and demo apps. Thoughts?

@bplattenburg
Copy link
Member Author

I propose we always build tools on the latest SDK (e.g., 4.9.1) to include the newest fixes and features. For users needing older versions, we can tag tools with SDK releases (e.g., v4.8.3-tools). This approach keeps us current while providing access to legacy-compatible tools and demo apps. Thoughts?

We discussed this a bit earlier, but I wanted to capture it here as well.

Today, we try to keep the minimum version relatively low to allow flexibility for customers to use the latest tools with multiple SDK versions, and only update it when there is meaningful impact. Any SDK version update is also considered a SemVer major change because it could be breaking for a customer, so we try to minimize those when possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants