Skip to content
This repository has been archived by the owner on Apr 29, 2022. It is now read-only.

doc: Document scanner rules in Markdown #77

Merged
merged 14 commits into from
Jan 14, 2022
Merged

doc: Document scanner rules in Markdown #77

merged 14 commits into from
Jan 14, 2022

Conversation

kgilpin
Copy link
Contributor

@kgilpin kgilpin commented Jan 11, 2022

No description provided.

@kgilpin kgilpin changed the base branch from main to feat/insecure-compare-ref January 12, 2022 18:54
Base automatically changed from feat/insecure-compare-ref to main January 12, 2022 18:56
@kgilpin kgilpin force-pushed the doc/rules branch 3 times, most recently from ea22d4d to cd587fe Compare January 12, 2022 18:59
dividedmind
dividedmind suggested changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@dividedmind dividedmind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I've found a couple of mistakes and typos; these should be easy to fix (I provided patches). Reading the docs also prompted some thoughts on the rules themselves, they might lead to new issues being opened; let's discuss.

doc/rules/circularDependency.md Outdated Show resolved Hide resolved
doc/rules/http500.md Outdated Show resolved Hide resolved
doc/rules/illegalPackageDependency.md Outdated Show resolved Hide resolved
doc/rules/incompatibleHttpClientRequest.md Outdated Show resolved Hide resolved
doc/rules/jobNotCancelled.md Outdated Show resolved Hide resolved
doc/rules/slowQuery.md Outdated Show resolved Hide resolved
doc/rules/tooManyJoins.md Outdated Show resolved Hide resolved
doc/rules/tooManyJoins.md Outdated Show resolved Hide resolved
src/rules/saveWithoutValidation.ts Show resolved Hide resolved
src/types.d.ts Show resolved Hide resolved
@kgilpin kgilpin force-pushed the doc/rules branch 3 times, most recently from d393ab5 to 0c148d9 Compare January 14, 2022 16:21
@kgilpin
Copy link
Contributor Author

kgilpin commented Jan 14, 2022

@dividedmind I'm going to merge this, and you can submit any change requests as a follow-on.

@kgilpin kgilpin merged commit d88684d into main Jan 14, 2022
@kgilpin kgilpin deleted the doc/rules branch January 14, 2022 18:26
@appland-release
Copy link

🎉 This PR is included in version 1.34.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@dividedmind dividedmind mentioned this pull request Jan 14, 2022
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@torchello torchello Awaiting requested review from torchello

@dustinbyrne dustinbyrne Awaiting requested review from dustinbyrne

@dividedmind dividedmind Awaiting requested review from dividedmind

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kgilpin @appland-release @dividedmind