fix: Handle exceptions raised by getters during parameter serialization #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was spotted in the wild, where the getter was overwritten to make sure an object was not used as a value.
dividedmind
approved these changes
Aug 5, 2024
|
🎉 This PR is included in version 2.23.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses an issue where exceptions raised by getters during parameter serialization were not handled properly. A test case was added to ensure that the parameter function does not throw an error when encountering a "get" trap, and the
isSimpleObjectfunction was updated to catch exceptions and return false if an error occurs.This pull request ensures stability when dealing with objects that have getters that could potentially throw exceptions, preventing crashes and ensuring that such objects are treated as non-simple.
E.g. https://github.com/nestjs/nest/blob/233a89ab3d84d814bb795f738be15216f5b30ed9/packages/common/module-utils/configurable-module.builder.ts#L331-L346
Fixes #158