fix: detect packages in multi-project repositories #290
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #283.
This PR addresses the issue of failure to autodetect package names in some multi-project repositories. Specifically, the Java AppMap agent was unable to auto-detect packages in the multi-project structure of the Retrofit repository. The agent only looked for
src/main/java
directories, which led to anappmap.yml
configuration file with no detected packages, as shown below:The repository is structured with multiple subprojects, each containing their own
src/main/java
directories:Changes Made
AppMapConfig.java: Updated
AppMapConfig.java
to traverse the root directory and collect packages from all relevantsrc/main/java
directories across subprojects.collectPackages
to encapsulate the logic for collecting Java packages.src/main/java
subdirectories.agent_cli.bats: Updated the test for the CLI agent initialization to verify the detection of packages within subprojects.
Test Project Structure: Added a sample subproject structure to the test project for verifying the updated behavior.