Add Windows build, fix NPE adding agent jar #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apotterri
force-pushed
the
windows-20231006
branch
2 times, most recently
from
1bdba08
to
377bbe0
Compare
apotterri
force-pushed
the
windows-20231006
branch
10 times, most recently
from
7d3c454
to
9c643fd
Compare
Make various tweaks to allow tests to run in a Git Bash environment on a GitHub build runner. This includes disabling a couple of tests that have proved challenging to port. They run fine on other platforms, though, which should be sufficient to show that the functionality works. These changes also converts the files containing those tests to JUnit 5.
apotterri
force-pushed
the
windows-20231006
branch
12 times, most recently
from
fd895b2
to
a6a367e
Compare
Use jcmd instead of ps. Add ExitController for PetClinic, use it to stop the server, instead of trying to use kill.
The CodeSource and location of the agent jar's ProtectionDomain can both be null (though the latter was only documented post-1.8). Only try to add the jar if both are available. Also, when the location URL is not null, convert it to a URI instead of a Path. This works on all platforms.
apotterri
force-pushed
the
windows-20231006
branch
from
a6a367e
to
1a165fa
Compare
dustinbyrne
approved these changes
Oct 12, 2023
|
🎉 This PR is included in version 1.22.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a GH action to run a build on Windows, Linux, and macOS.
Also, only try to add the agent jar to the classpath if its location is available.
Fix #225.