Debounce requests for a filesystem refresh #805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reduces the flickering of the "Indexing..." progress indicator in the status bar.
AppMap runtime code review
|
dustinbyrne
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #665
This reduces the flickering of the "Indexing..." progress indicator in the status bar when a lot of AppMap data changes in a short time interval. This happens when multiple test cases are executed, for example.
I extracted the refresh logic from the command line service into a new service for better separation and easier testing.
There's already a test case covering the refresh request handling.
There's no test to test the debouncing of the requests, I don't think that there's a way to do this.