Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify what NavieEditor.addPinnedFiles does #800

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

jansorg
Copy link
Collaborator

@jansorg jansorg commented Oct 8, 2024

Closes #799

Method NavieEditor.addPinnedFiles does verify the file size, but I did not remember this.
This PR makes the documentation more clear.

@jansorg jansorg requested a review from apotterri October 8, 2024 13:30
Copy link

github-actions bot commented Oct 8, 2024

AppMap runtime code review

Summary Status
Failed tests ✅ All tests passed
API changes 0️⃣ No API changes
Security flaws ✅ None detected
Performance problems ✅ None detected
Code anti-patterns ✅ None detected
New AppMaps 0️⃣ No new AppMaps

@apotterri apotterri merged commit 8bcdaf8 into develop Oct 9, 2024
7 checks passed
@apotterri apotterri deleted the jansorg/navie-max-file-size branch October 9, 2024 18:01
@appland-release
Copy link
Contributor

🎉 This PR is included in version 0.75.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ChooseAndAddNavieContextFilesAction does not check for the configured max file size
3 participants