-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement pinned files for the Navie editor #786
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jansorg
force-pushed
the
jansorg/navie-pin
branch
from
September 18, 2024 11:48
e3032b6
to
e164d4f
Compare
jansorg
force-pushed
the
jansorg/navie-pin
branch
2 times, most recently
from
September 18, 2024 12:28
15427e9
to
558faee
Compare
jansorg
force-pushed
the
jansorg/navie-pin
branch
from
September 18, 2024 12:29
558faee
to
814f24b
Compare
jansorg
force-pushed
the
jansorg/navie-pin
branch
5 times, most recently
from
September 23, 2024 09:29
ab1b0d0
to
aa247e7
Compare
jansorg
force-pushed
the
jansorg/navie-pin
branch
from
September 23, 2024 09:34
aa247e7
to
4891413
Compare
apotterri
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the tests.
🎉 This PR is included in version 0.75.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #789
Support for pinned context files in the IDE.
Added actions:
Tools > AppMap
main menu: "Add Files to Navie Context". This action is available in the global list of actions as "AppMap: Add Files to Navie Context"The default max size of pinned files is 20 KB (as in VSCode). There's a new, application-wide setting to override this value.
I looked into support for Drag&Drop, unfortunately it's not possible to implement this in a reasonable time:
CustomFileDropHandler
in older andFileDropHandler
in newer versions of the IDE. Both only provide access to the editor if the editor provides special support for Drag&Drop. The SDK only provides this support for text file editors. We're using a custom, JCEF-based "editor" for the Navie editor. Investigating and possibly adding support for Drag&Drop would a lot of time and I'm not even certain if this would work.Test coverage: I've added tests, but because JCEF is not available on headless systems like CI some of these tests are only executed on a local development environment.
Project view context menu:
Context menu of an editor tab:
Notification if file was too large:
Tools menu to choose files with file chooser:
UI for the new setting: