Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement pinned files for the Navie editor #786

Merged
merged 3 commits into from
Sep 25, 2024
Merged

Conversation

jansorg
Copy link
Collaborator

@jansorg jansorg commented Sep 17, 2024

Closes #789

Support for pinned context files in the IDE.

Added actions:

  • In the context menu of the problems view tab: "AppMap: Add files to Navie Context"
  • In the Tools > AppMap main menu: "Add Files to Navie Context". This action is available in the global list of actions as "AppMap: Add Files to Navie Context"

The default max size of pinned files is 20 KB (as in VSCode). There's a new, application-wide setting to override this value.

I looked into support for Drag&Drop, unfortunately it's not possible to implement this in a reasonable time:

  • There's CustomFileDropHandler in older and FileDropHandler in newer versions of the IDE. Both only provide access to the editor if the editor provides special support for Drag&Drop. The SDK only provides this support for text file editors. We're using a custom, JCEF-based "editor" for the Navie editor. Investigating and possibly adding support for Drag&Drop would a lot of time and I'm not even certain if this would work.

Test coverage: I've added tests, but because JCEF is not available on headless systems like CI some of these tests are only executed on a local development environment.

Project view context menu:
image

Context menu of an editor tab:
image

Notification if file was too large:
image

Tools menu to choose files with file chooser:
image

UI for the new setting:
image

@jansorg jansorg marked this pull request as ready for review September 18, 2024 12:12
@jansorg jansorg force-pushed the jansorg/navie-pin branch 2 times, most recently from 15427e9 to 558faee Compare September 18, 2024 12:28
@jansorg jansorg force-pushed the jansorg/navie-pin branch 5 times, most recently from ab1b0d0 to aa247e7 Compare September 23, 2024 09:29
Copy link
Contributor

@apotterri apotterri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the tests.

@apotterri apotterri merged commit 55d743d into develop Sep 25, 2024
7 checks passed
@apotterri apotterri deleted the jansorg/navie-pin branch September 25, 2024 13:11
@appland-release
Copy link
Contributor

🎉 This PR is included in version 0.75.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Navie pinned files
3 participants