Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEATURE: Enhanced pod management and volume detachment during non-graceful node shutdowns #6

Merged
merged 1 commit into from
Apr 16, 2024
Merged

FEATURE: Enhanced pod management and volume detachment during non-graceful node shutdowns #6

merged 1 commit into from
Apr 16, 2024

Conversation

Downager
Copy link
Contributor

@Downager Downager commented Apr 2, 2024 •
edited
Loading

Allow ASG (Auto Scaling Group) lifecycle hooks to:

@Downager Downager force-pushed the feat/add-force-delete-pod branch from 36e712a to 8f20ed1 Compare April 9, 2024 06:26
@Downager Downager force-pushed the feat/add-force-delete-pod branch from 8f20ed1 to 93a85a9 Compare April 9, 2024 07:12
@Downager Downager changed the title FEATURE: Allow ASG lifecycle hooks to force delete pods once the timeout is reached FEATURE: Enhanced pod management and volume detachment during non-graceful node shutdowns Apr 9, 2024
@Downager Downager mentioned this pull request Apr 11, 2024
Merged
@Downager Downager added this to the v1.27.4.2 milestone Apr 11, 2024
smalltown
smalltown approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@smalltown smalltown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thanks!

@Downager Downager merged commit 111fa15 into master Apr 16, 2024
2 checks passed
@Downager Downager deleted the feat/add-force-delete-pod branch April 16, 2024 03:22
Downager added a commit to getamis/vishwakarma that referenced this pull request Apr 16, 2024
@Downager
FEATURE: Enhanced ASG lifecycle hooks during non-graceful node shutdo…
2b9b52e 
…wns (#186)

getamis/terraform-aws-asg-lifecycle#6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smalltown smalltown smalltown approved these changes

@soem soem Awaiting requested review from soem

@chechiachang chechiachang Awaiting requested review from chechiachang

@charles-hsiao charles-hsiao Awaiting requested review from charles-hsiao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.27.4.2
Development

Successfully merging this pull request may close these issues.
2 participants
@Downager @smalltown