[WIP] consensus, core, eth, miner: use the same insert behavior between proposer and validators #123

markya0616 · 2017-07-17T06:09:38Z

…poser and validators

markya0616 · 2017-07-17T06:45:43Z

consensus/istanbul/core/preprepare.go

-				c.sendEvent(backlogEvent{
-					src: src,
-					msg: msg,
+	if !c.valSet.IsProposer(c.Address()) {


core isProposer()

markya0616 · 2017-07-17T06:47:26Z

core/blockchain.go

@@ -838,6 +838,11 @@ func (bc *BlockChain) WriteBlock(block *types.Block) (status WriteStatus, err er
 	bc.mu.Lock()
 	defer bc.mu.Unlock()

+	if bc.HasBlock(block.Hash()) {
+		log.Info("Block exists", "hash", block.Hash())


yutelin · 2017-07-21T03:21:37Z

consensus/istanbul/backend/backend.go

+	logger             log.Logger
+	db                 ethdb.Database
+	chain              consensus.ChainReader
+	commitProposedWork func(*types.Block) error


comment more on commitProposedWork and writeProposedWork

yutelin · 2017-07-21T03:26:02Z

Please elaborate what the major difference from previous implementation is.
What we did before and what we do right now.

For example, previously proposer inserts the block through __ and validator insert the block through __.
And now, proposer and validators are the same. They call commitProposedWork during __ step to __? And call writeProposedWork during __ step for __ ?

markya0616 · 2017-07-24T06:59:35Z

OK. In previous implementation, we only verify block's header in Verify() and call InsertChain to insert committed blocks. We don't check the correctness of the block body in Verfiy(), so we may try to lock or commit a block with incorrect body. In this PR, we created an Istanbul worker to improve system performance and check block body (i.e., transactions) in Verify().
The procedure are as follows:

Proposer call commitNewWork() to create a block after receiving NewBlockEvent event
Proposer broadcasts the proposed blocks to other validators
After validators received the proposed block, they call commitProposedWork() and then apply the transactions in the block to check the correctness of the block's body and header.
If we received 2F+1 commits, we call writeProposedWork() to write the committed block into chain db.

* consensus/istanbul: handle future preprepare * consensus/istanbul: handle request timeout in evnet loop * consensus, eth: start/stop core engine while start/stop mining * eth, ethstats: fix crash while reporting to ethstats * consensus/istanbul, miner: add new event to trigger new block creation * eth, consensus/istanbul: improve sending messages * consensus/istanbul: stop future preprepare timer while stop core * consensus/istanbul: add cache in ecrecover()

…ators

markya0616 · 2017-08-08T01:52:31Z

This PR changes too many stuffs. We need more tests for this PR before merge

stevenroose · 2018-01-24T10:10:05Z

Where can I report issues with Istanbul? I found one that might be slightly related to this change.

It's explained here in more detail: ethereum/EIPs#650 (comment)

markya0616 commented Jul 17, 2017

View reviewed changes

markya0616 force-pushed the validator_insert branch from 727c487 to df5d3a3 Compare July 18, 2017 02:29

markya0616 changed the base branch from improve_performance to feature/improve_performance July 18, 2017 02:29

markya0616 force-pushed the feature/improve_performance branch from bdfa43e to 6816e21 Compare July 18, 2017 02:30

markya0616 force-pushed the validator_insert branch from df5d3a3 to ad67a73 Compare July 18, 2017 03:15

yutelin changed the title ~~consensus, core, eth, miner: use the same insert behavior between pro…~~ consensus, core, eth, miner: use the same insert behavior between proposer and validators Jul 21, 2017

yutelin reviewed Jul 21, 2017

View reviewed changes

markya0616 force-pushed the feature/improve_performance branch from 6816e21 to 39eaf7c Compare July 22, 2017 13:20

markya0616 force-pushed the validator_insert branch from ad67a73 to 12498ce Compare July 24, 2017 06:44

markya0616 changed the base branch from feature/improve_performance to istanbul/develop July 24, 2017 06:45

markya0616 force-pushed the validator_insert branch from 12498ce to 765b10c Compare July 24, 2017 07:03

tailingchen and others added 16 commits July 31, 2017 17:48

eth: add protocol manager interface and refactoring

7791eac

params: add Istanbul consensus engine config to ChainConfig

6f01d12

cmd/*: add Istanbul command line flags

5e8aa15

consensus/istanbul, eth: add Istanbul configuration

219aa5e

node: add an interface to retrieve node key from config

b7366b3

consensus: add Istanbul consensus engine interface

da8d588

consensus/istanbul: common Istanbul interfaces and types

519ec6e

consensus/istanbul: Istanbul validator set implementation

885035c

consensus/istanbul: Istanbul core implementation

e69dedf

consensus/istanbul: add tests for Istanbul core

49aa279

core/types: add Istanbul specific block hash calculation

2ce3c53

consensus/istanbul: Istanbul consensus backend implementation

443b0f9

internal/web3ext: add Istanbul JS RPC API

e2d561f

eth: Istanbul consensus integration

2b7bda3

cmd/*, core, params: add ottoman testnet

f2f493b

consensus/istanbul: set timeout based on round

3730ecf

tailingchen force-pushed the istanbul/develop branch from b59c7d0 to dccfb94 Compare July 31, 2017 09:58

markya0616 and others added 2 commits August 1, 2017 14:41

travis: update travis notification url

2d811e4

markya0616 force-pushed the istanbul/develop branch from 4d6d507 to 2d811e4 Compare August 1, 2017 06:44

markya0616 added 2 commits August 1, 2017 15:28

miner, consensus/istanbul: use Istanbul worker

b74d4df

consensus, core, eth, miner: use the same insert behavior among valid…

373a847

…ators

markya0616 force-pushed the validator_insert branch from 765b10c to 373a847 Compare August 1, 2017 07:29

markya0616 force-pushed the istanbul/develop branch from 164faea to 35d36a2 Compare August 7, 2017 15:09

markya0616 changed the title ~~consensus, core, eth, miner: use the same insert behavior between proposer and validators~~ [WIP] consensus, core, eth, miner: use the same insert behavior between proposer and validators Aug 8, 2017

markya0616 force-pushed the istanbul/develop branch from 35d36a2 to fda548f Compare August 14, 2017 06:19

markya0616 force-pushed the istanbul/develop branch 3 times, most recently from f152944 to adc0cb8 Compare August 25, 2017 07:12

markya0616 force-pushed the istanbul/develop branch 2 times, most recently from 1d28a1c to 6eb4e85 Compare September 15, 2017 07:09

markya0616 force-pushed the istanbul/develop branch 2 times, most recently from b389e13 to cfc586a Compare October 4, 2017 03:06

markya0616 force-pushed the istanbul/develop branch from cfc586a to 07dc51b Compare November 9, 2017 03:29

markya0616 force-pushed the istanbul/develop branch from 07dc51b to 4cb4e46 Compare November 23, 2017 03:31

markya0616 force-pushed the istanbul/develop branch from 4cb4e46 to 5ab6775 Compare December 18, 2017 02:52

markya0616 force-pushed the istanbul/develop branch 2 times, most recently from cb3c2e1 to 3d49176 Compare January 23, 2018 01:59

markya0616 force-pushed the istanbul/develop branch from daaeb0a to 9502792 Compare March 26, 2018 09:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] consensus, core, eth, miner: use the same insert behavior between proposer and validators #123

[WIP] consensus, core, eth, miner: use the same insert behavior between proposer and validators #123

markya0616 commented Jul 17, 2017

markya0616 Jul 17, 2017

markya0616 Jul 18, 2017

markya0616 Jul 18, 2017

markya0616 Jul 17, 2017

markya0616 Jul 18, 2017

markya0616 Jul 18, 2017

yutelin Jul 21, 2017

markya0616 Jul 24, 2017

yutelin commented Jul 21, 2017

markya0616 commented Jul 24, 2017

markya0616 commented Aug 8, 2017

stevenroose commented Jan 24, 2018 •

edited

Loading

[WIP] consensus, core, eth, miner: use the same insert behavior between proposer and validators #123

Are you sure you want to change the base?

[WIP] consensus, core, eth, miner: use the same insert behavior between proposer and validators #123

Conversation

markya0616 commented Jul 17, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yutelin commented Jul 21, 2017

markya0616 commented Jul 24, 2017

markya0616 commented Aug 8, 2017

stevenroose commented Jan 24, 2018 • edited Loading

stevenroose commented Jan 24, 2018 •

edited

Loading