For #175: Add tests and fixes for twophase(method="simple")
.
#180
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes sure that 'srvyr' works for designs where the user specifies
twophase(..., method = "simple")
.Everything so far operated on the assumption that users would be using
twophase(..., method = "full")
, which is why we see the problems faced in #175.I copied the tests we're using for
method = "full"
and extended them for the case wheremethod = "simple"
, which caught the problem raised in #175. To make things work, I added asubset_svy_vars()
method for objects with classtwophase
, and otherwise in the helper functions just updated a couple checks in places to ensure thattwophase
objects get treated liketwophase2
objects wherever possible.