Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For #175: Add tests and fixes for twophase(method="simple"). #180

Merged
merged 1 commit into from
Oct 5, 2024

Conversation

bschneidr
Copy link
Contributor

This PR makes sure that 'srvyr' works for designs where the user specifies twophase(..., method = "simple").

Everything so far operated on the assumption that users would be using twophase(..., method = "full"), which is why we see the problems faced in #175.

I copied the tests we're using for method = "full" and extended them for the case where method = "simple", which caught the problem raised in #175. To make things work, I added a subset_svy_vars() method for objects with class twophase, and otherwise in the helper functions just updated a couple checks in places to ensure that twophase objects get treated like twophase2 objects wherever possible.

Copy link
Owner

@gergness gergness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thanks so much!

@gergness gergness merged commit def440c into gergness:main Oct 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants