Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui(qchat): vertically optimize the QChat widget #216

Merged
merged 5 commits into from
Nov 14, 2024

Conversation

gounux
Copy link
Contributor

@gounux gounux commented Nov 1, 2024

No description provided.

@github-actions github-actions bot added the UI User interface: forms, widgets... label Nov 1, 2024
@Guts
Copy link
Member

Guts commented Nov 4, 2024

I've fixed a buggy import and still have an error initilizing the QChat:

Une erreur est survenue lors de l'exécution du code Python : 

KeyError: 'type' 
Traceback (most recent call last):
  File "/home/jmo/Git/Geotribu/qtribu/qtribu/logic/qchat_websocket.py", line 100, in on_message_received
    msg_type = message["type"]
               ~~~~~~~^^^^^^^^
KeyError: 'type'


Version de Python : 3.12.3 (main, Sep 11 2024, 14:17:37) [GCC 13.2.0] 
Version de QGIS : 3.34.12-Prizren Prizren, eeb6af36386 

Chemin Python :
/usr/share/qgis/python
/home/jmo/.local/share/QGIS/QGIS3/profiles/plg_qtribu/python
/home/jmo/Git/Geotribu/qtribu
/home/jmo/.local/share/QGIS/QGIS3/profiles/plg_qtribu/python/plugins
/usr/share/qgis/python/plugins
/usr/lib/python312.zip
/usr/lib/python3.12
/usr/lib/python3.12/lib-dynload
/usr/local/lib/python3.12/dist-packages
/usr/lib/python3/dist-packages
/home/jmo/.local/share/QGIS/QGIS3/profiles/plg_qtribu/python

I guess it's related to the gischat v2?

@gounux
Copy link
Contributor Author

gounux commented Nov 4, 2024

I've fixed a buggy import and still have an error initilizing the QChat:

Thanks !

I guess it's related to the gischat v2?

Yes I think so, now every JSON message has a type key.
You can check it by setting the following Instance URI in the settings https://staging.gischat.geotribu.net

Do you think it might need some further checks so that this does not happen ?

@Guts
Copy link
Member

Guts commented Nov 4, 2024

Do you think it might need some further checks so that this does not happen ?

Not sure, sounds overkill. Or maybe a simple compatible versions matrix in the plugin, like {"gischat_compatible_versions": ">=2.0.0"}?

Copy link

sonarcloud bot commented Nov 6, 2024

@gounux gounux merged commit 4971448 into main Nov 14, 2024
12 checks passed
@gounux gounux deleted the ui/vertically-optimized-widget branch November 14, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI User interface: forms, widgets...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants