Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refacto(json_feed_client): utilise le file downloader pour mutualiser le code #226

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

Guts
Copy link
Member

@Guts Guts commented Jul 2, 2024

No description provided.

@Guts Guts self-assigned this Jul 2, 2024
@Guts Guts requested a review from gounux July 2, 2024 12:09
@github-actions github-actions bot added the enhancement New feature or request label Jul 2, 2024
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.30%. Comparing base (5a69ec5) to head (a0d2011).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #226      +/-   ##
==========================================
+ Coverage   67.02%   67.30%   +0.28%     
==========================================
  Files          43       43              
  Lines        1971     1988      +17     
  Branches      351      355       +4     
==========================================
+ Hits         1321     1338      +17     
  Misses        567      567              
  Partials       83       83              
Flag Coverage Δ
unittests 67.05% <100.00%> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
geotribu_cli/constants.py 98.63% <100.00%> (+0.19%) ⬆️
geotribu_cli/json/json_client.py 100.00% <100.00%> (ø)

Copy link
Contributor

@gounux gounux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merci @Guts, j'avais pas vu la fonction download_remote_file_to_local, ce sera l'occasion de l'utiliser pour les index et dimensions des images ;)

geotribu_cli/constants.py Outdated Show resolved Hide resolved
geotribu_cli/json/json_client.py Show resolved Hide resolved
@Guts Guts force-pushed the feature/use-downloader-in-json-feed-client branch from b0c1c9b to a0d2011 Compare July 2, 2024 12:54
Copy link

sonarcloud bot commented Jul 2, 2024

@Guts Guts requested a review from gounux July 2, 2024 15:31
@Guts Guts merged commit f33e162 into main Jul 2, 2024
30 of 31 checks passed
@Guts Guts deleted the feature/use-downloader-in-json-feed-client branch July 2, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants