Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed unnecessary lifetimes #153

Merged
merged 3 commits into from
Apr 30, 2024
Merged

Removed unnecessary lifetimes #153

merged 3 commits into from
Apr 30, 2024

Conversation

ManeraKai
Copy link
Contributor

Fixes #152 and 2) Lifetimes part of #141

@kylebarron
Copy link
Member

I haven't fully read through the diff yet but this looks awesome and I'm really excited for this. (With the caveat that I don't know C FFI well enough to know if there's any relation between removing named lifetimes and FFI safety). In geoarrow-rs I've struggled around GEOS lifetimes a decent amount with conversions to/from geoarrow.

@GuillaumeGomez
Copy link
Member

Looks good to me, thanks a lot! Please run cargo fmt. You can ignore the memory leaks failures in the CI.

@GuillaumeGomez GuillaumeGomez merged commit f1bed58 into georust:master Apr 30, 2024
9 of 15 checks passed
@GuillaumeGomez
Copy link
Member

Gonna make a new release "soon".

@ManeraKai
Copy link
Contributor Author

ManeraKai commented Apr 30, 2024 •
edited
Loading

We are using geos for a university project. Please make it more "soon".

@michaelkirk
Copy link
Member

If it's really so urgent you can patch your dependency.

@GuillaumeGomez
Copy link
Member

We are using geos for a university project. Please make it more "soon".

For faster things, you can sponsor me. Otherwise, please be patient or follow @michaelkirk great advice.

@ManeraKai
Copy link
Contributor Author

Alright.

@GuillaumeGomez
Copy link
Member

Released the new 9.0.0 version.

@kylebarron kylebarron mentioned this pull request May 3, 2024
Merged
kylebarron added a commit to geoarrow/geoarrow-rs that referenced this pull request May 3, 2024
@kylebarron
Update geos to 9.0 (#626)
23c226b 
We can remove a lot of lifetime definitions thanks to
georust/geos#153
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Why I can only create Geometry<'static>?
4 participants
@ManeraKai @kylebarron @GuillaumeGomez @michaelkirk