LdapAccountsManager - skip organization creation of org is empty #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
some IdP (e.g. FranceConnect) seem to return a blank ("") organization,
we cannot rely on the `try {} catch (NameNotFoundException)` here, but
at least we can just skip the org creation if we don't have at least a
name to create it.
We don't handle the case "put the user into a default organization" on
purpose, as I don't think this has been specified.
Tests: updated testsuite to take into account blank org.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one supersedes #79, takes back my previous one (#78), but since the preauthentication PR has now been merged, it allows me to add an integration test to reveal the bug it attempts to fix.
some IdP (e.g. FranceConnect) seem to return a blank ("") organization, we cannot rely on the
try {} catch (NameNotFoundException)here, but at least we can just skip the org creation if we don't have at least a name to create it.We don't handle the case "put the user into a default organization" on purpose, as I don't think this has been specified.
Tests: updated testsuite to take into account blank org.