headers filters - custom service configuration should override default headers configuration (#120) #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Custom service header mappings not applied due to Spring Boot
not correctly parsing `Service.headers: Optional<HeaderMappings>`.
Apparently using `Optional` for `@ConfigurationProperties` is ok for
scalars but not for nested objects.
So a service header definitions like
```
datafeeder:
target: ${georchestra.gateway.services.datafeeder.target}
headers:
json-user: true
json-organization: true
```
Wouldn't get the json-user and json-organization request headers applied
to downstream services.
|
Note the build failure: is unrelated and seems to be there since a while ago |
yes we noticed it, we might just deactivate for now and revisit later (from what I investigated it fails because it relies on the console container output, so if something changes in the way the console is logging, then the test fails). |
pmauduit
commented
Sep 11, 2024
gateway/src/main/java/org/georchestra/gateway/model/GeorchestraOrganizations.java
Show resolved
Hide resolved
gateway/src/main/java/org/georchestra/gateway/model/GeorchestraUsers.java
Show resolved
Hide resolved
gateway/src/main/java/org/georchestra/gateway/filter/global/ResolveTargetGlobalFilter.java
Show resolved
Hide resolved
...ain/java/org/georchestra/gateway/filter/headers/providers/JsonPayloadHeadersContributor.java
Show resolved
Hide resolved
Check the account creation onto the LDAP instead of parsing the console output.
added a commit to deactivate it. Reading the output, it seems that the issue is console-side. |
Note: with a console docker image compiled with georchestra/georchestra#4332 the test passes.
With georchestra/georchestra#4332 we could reactivate the test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #120
Fix custom service header mappings not being applied
Custom service header mappings not applied due to Spring Boot not correctly parsing
Service.headers: Optional<HeaderMappings>.Apparently using
Optionalfor@ConfigurationPropertiesis ok for scalars but not for nested objects.So a service header definitions like
Wouldn't get the json-user and json-organization request headers applied to downstream services.