Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Elasticsearch and MongoDB in CI to match pygeoapi-examples #1914

Merged
merged 1 commit into from
Jan 26, 2025

Conversation

tomkralidis
Copy link
Member

Overview

Bumps Elasticsearch and MongoDB versions in CI to match official examples in pygeoapi-examples.

Related Issue / discussion

geopython/pygeoapi-examples#22

Additional information

Dependency policy (RFC2)

  • I have ensured that this PR meets RFC2 requirements

Updates to public demo

Contributions and licensing

(as per https://github.com/geopython/pygeoapi/blob/master/CONTRIBUTING.md#contributions-and-licensing)

  • I'd like to contribute [feature X|bugfix Y|docs|something else] to pygeoapi. I confirm that my contributions to pygeoapi will be compatible with the pygeoapi license guidelines at the time of contribution
  • I have already previously agreed to the pygeoapi Contributions and Licensing Guidelines

@tomkralidis tomkralidis added the tests Tests label Jan 25, 2025
@tomkralidis tomkralidis added this to the 0.20.0 milestone Jan 25, 2025
@tomkralidis tomkralidis requested a review from a team January 25, 2025 14:28
Copy link
Member

@webb-ben webb-ben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Might be worth eventually implementing tests with https://testcontainers.com wherever possible to run these tests without needing to spawn the corresponding database outside of the test context.

@tomkralidis tomkralidis merged commit 269c785 into master Jan 26, 2025
6 checks passed
@tomkralidis tomkralidis deleted the es-mongo-test-versions branch January 26, 2025 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants