Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement OGC API Features Part 4 transactions for the postgres provider #1891

Merged

Conversation

totycro
Copy link
Contributor

@totycro totycro commented Dec 30, 2024

Overview

This PR implements create(), update() and delete() in the postgres provider. The behavior is analogous to implementations in other providers and as defined by the standard.

The implementation is pretty basic, i can add more advanced logic if necessary (e.g. inputs which are not in WGS 84).

Additional information

Dependency policy (RFC2)

  • I have ensured that this PR meets RFC2 requirements

Updates to public demo

Contributions and licensing

(as per https://github.com/geopython/pygeoapi/blob/master/CONTRIBUTING.md#contributions-and-licensing)

  • I'd like to contribute [feature X|bugfix Y|docs|something else] to pygeoapi. I confirm that my contributions to pygeoapi will be compatible with the pygeoapi license guidelines at the time of contribution
  • I have already previously agreed to the pygeoapi Contributions and Licensing Guidelines

@totycro totycro requested a review from tomkralidis December 30, 2024 14:24
@tomkralidis tomkralidis added the OGC API - Features OGC API - Features label Dec 30, 2024
Copy link
Member

@tomkralidis tomkralidis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good, thanks @totycro !

Please mark transactions as supported in PostgreSQL in the providers table.

@tomkralidis tomkralidis added this to the 0.19.0 milestone Dec 30, 2024
@tomkralidis tomkralidis added the enhancement New feature or request label Dec 30, 2024
@tomkralidis tomkralidis merged commit 5628529 into geopython:master Dec 30, 2024
4 checks passed
@tomkralidis tomkralidis deleted the implement-ogc-transactions-for-postgres branch December 30, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request OGC API - Features OGC API - Features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants