Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oracle Connection Pooling implementation of issues/1655 #1688

Merged
merged 22 commits into from
Jun 21, 2024

Conversation

Moritz-Langer
Copy link
Contributor

Overview

This is an implementation of connection pooling in oracle. It leaves the decision up to the environment, if the variables
ORACLE_POOL_MIN and ORACLE_POOL_MAX are found in the environment, a Pool is created with min and max connections according to the variable values. If they are not set, than single connections are used, just like before.
This should lead to no breaks for current users and is easy to set up.

Tests and Documentation are added as well.

Related Issue / discussion

Related to #1655

Additional information

Dependency policy (RFC2)

  • I have ensured that this PR meets RFC2 requirements

Updates to public demo

Contributions and licensing

(as per https://github.com/geopython/pygeoapi/blob/master/CONTRIBUTING.md#contributions-and-licensing)

  • I'd like to contribute [feature X|bugfix Y|docs|something else] to pygeoapi. I confirm that my contributions to pygeoapi will be compatible with the pygeoapi license guidelines at the time of contribution
  • I have already previously agreed to the pygeoapi Contributions and Licensing Guidelines

@Moritz-Langer Moritz-Langer changed the title Oracle Connection Pooling https://github.com/geopython/pygeoapi/issues/1655 Oracle Connection Pooling implementation of issues/1655 Jun 19, 2024
@Moritz-Langer
Copy link
Contributor Author

@8luewater fyi

@tomkralidis tomkralidis self-requested a review June 19, 2024 15:26
@tomkralidis tomkralidis added enhancement New feature or request OGC API - Features OGC API - Features labels Jun 19, 2024
@tomkralidis tomkralidis added this to the 0.17.0 milestone Jun 19, 2024
pygeoapi/provider/oracle.py Show resolved Hide resolved
pygeoapi/provider/oracle.py Show resolved Hide resolved
Copy link
Member

@tomkralidis tomkralidis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting a few minor changes -- good work!

@Moritz-Langer
Copy link
Contributor Author

Hi Tom,
thank you for the feedback and the review. I have adjusted according to your comments.

@tomkralidis tomkralidis merged commit c607be7 into geopython:master Jun 21, 2024
5 checks passed
@totycro totycro deleted the oracle_connection_pooling branch June 24, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request OGC API - Features OGC API - Features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants