-
-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Oracle Connection Pooling implementation of issues/1655 #1688
Merged
tomkralidis
merged 22 commits into
geopython:master
from
totycro:oracle_connection_pooling
Jun 21, 2024
Merged
Oracle Connection Pooling implementation of issues/1655 #1688
tomkralidis
merged 22 commits into
geopython:master
from
totycro:oracle_connection_pooling
Jun 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First part of collection pooling, improve by making pool size and other params configurable in YAML file of pygeoapi
…CLE_POOL_MAX are set. Else usual behaviour is restored and single connections are opened and closed. Added a Lock for avoiding race conditions and threat safety.
Merge Origin/Master into branch
Merge new Master Commits in Branch
Added Author
Moritz-Langer
changed the title
Oracle Connection Pooling https://github.com/geopython/pygeoapi/issues/1655
Oracle Connection Pooling implementation of issues/1655
Jun 19, 2024
@8luewater fyi |
totycro
approved these changes
Jun 19, 2024
tomkralidis
added
enhancement
New feature or request
OGC API - Features
OGC API - Features
labels
Jun 19, 2024
tomkralidis
approved these changes
Jun 19, 2024
tomkralidis
requested changes
Jun 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting a few minor changes -- good work!
Hi Tom, |
tomkralidis
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This is an implementation of connection pooling in oracle. It leaves the decision up to the environment, if the variables
ORACLE_POOL_MIN
andORACLE_POOL_MAX
are found in the environment, a Pool is created with min and max connections according to the variable values. If they are not set, than single connections are used, just like before.This should lead to no breaks for current users and is easy to set up.
Tests and Documentation are added as well.
Related Issue / discussion
Related to #1655
Additional information
Dependency policy (RFC2)
Updates to public demo
Contributions and licensing
(as per https://github.com/geopython/pygeoapi/blob/master/CONTRIBUTING.md#contributions-and-licensing)