Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Included exception info in the logs, if available #1446

Conversation

ricardogsilva
Copy link
Member

Overview

This PR modifies API.get.exception()'s already existing call to LOGGER.error() to include exception-related information, if available.

As a result of this modification, all calls to LOGGER.error() made just before a call to API.get_exception() also got removed, as the logging call that is inside the method is now able to show info related to exceptions.

Related Issue / Discussion

Contributions and Licensing

(as per https://github.com/geopython/pygeoapi/blob/master/CONTRIBUTING.md#contributions-and-licensing)

  • I'd like to contribute [feature X|bugfix Y|docs|something else] to pygeoapi. I confirm that my contributions to pygeoapi will be compatible with the pygeoapi license guidelines at the time of contribution.
  • I have already previously agreed to the pygeoapi Contributions and Licensing Guidelines

@ricardogsilva ricardogsilva force-pushed the 1442-logs-dont-have-error-information branch from bc056e5 to 1ee7864 Compare December 20, 2023 16:10
@ricardogsilva ricardogsilva marked this pull request as ready for review December 20, 2023 16:44
Copy link
Contributor

@doublebyte1 doublebyte1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related, but maybe update this to something like "exception description"?

:param description: OGC API exception code

Copy link

github-actions bot commented Apr 7, 2024

This Pull Request has been inactive for 90 days. As per RFC4, in order to manage maintenance burden, it will be automatically closed in 7 days.

@github-actions github-actions bot added the stale Issue marked stale by stale-bot label Apr 7, 2024
@ricardogsilva ricardogsilva force-pushed the 1442-logs-dont-have-error-information branch from 1ee7864 to b35f7c1 Compare April 12, 2024 21:24
@ricardogsilva
Copy link
Member Author

@tomkralidis rebased

@tomkralidis tomkralidis merged commit bf31885 into geopython:master Apr 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Issue marked stale by stale-bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

logs don't have error information
4 participants