Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement thermal conductivity plugins #6211

Merged
merged 4 commits into from
Jan 28, 2025

Conversation

gassmoeller
Copy link
Member

WIP

using namespace dealii;

/**
* A base class for parameterizations of material models. Classes derived
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this comment copy & pasted from the interface?

@gassmoeller gassmoeller force-pushed the add_conductivity_interface branch from cf15669 to bcda6ff Compare January 27, 2025 15:11
@gassmoeller gassmoeller force-pushed the add_conductivity_interface branch from bcda6ff to fcb9c59 Compare January 27, 2025 15:19
@gassmoeller gassmoeller changed the title [WIP] Implement thermal conductivity plugins Implement thermal conductivity plugins Jan 27, 2025
@gassmoeller gassmoeller force-pushed the add_conductivity_interface branch from 5445d23 to 11a545b Compare January 27, 2025 15:31
@gassmoeller
Copy link
Member Author

Thanks for the review, this was implemented very quickly to provide a starting point for someone at a workshop. I now cleaned up the PR to show the smallest possible implementation and use case. I also decided to keep it backward compatible for now (to let the plugin declare parameters relative to the existing subsection instead of in a new subsection). This way it will be easier to include in more material models. I will create a follow-up PR to show the benefits of this change in material models, but this PR should be ready for another look and could be merged independently.

@tjhei tjhei merged commit 70f4496 into geodynamics:main Jan 28, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants