Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is mostly improving code quality, although it could also lead to small performance improvements for a few models.
It does the following things:
q
like we do almost everywhereJxW
outside of assembly loops over degrees of freedom wherever possible. In many places that just assemble a right hand side (single loop over DoF) this likely doesnt make a difference, but a few places assemble matrices where this change might matter. Also I would just like to establish this as a pattern in as many places as possible so that future copy-paste code will copy the correct patternJxW
conversion also change a few places that can pre-compute values of shape functions or other expensive items from the inner loop. I dont expect huge performance gains, but it is a pattern we use in many places already, and if it is simple we should save the compute time where possible.