-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] use old strain-rate instead of current strain-rate to add as a reaction to strain fields of strain-dependent. #6141
Open
MFraters
wants to merge
1
commit into
geodynamics:main
Choose a base branch
from
MFraters:use_old_strain_rate_for_adding_to_plastic_strain_field
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -633,7 +633,32 @@ namespace aspect | |
ExcMessage("Invalid strain_rate in the MaterialModelInputs. This is likely because it was " | ||
"not filled by the caller.")); | ||
|
||
const double edot_ii = std::max(std::sqrt(std::max(-second_invariant(deviator(in.strain_rate[i])), 0.)), | ||
|
||
// Get old (previous time step) velocity gradients to compute the ol strain-rate | ||
std::vector<Point<dim>> quadrature_positions(in.n_evaluation_points()); | ||
quadrature_positions[i] = this->get_mapping().transform_real_to_unit_cell(in.current_cell, in.position[i]); | ||
|
||
std::vector<double> solution_values(this->get_fe().dofs_per_cell); | ||
in.current_cell->get_dof_values(this->get_old_solution(), | ||
solution_values.begin(), | ||
solution_values.end()); | ||
|
||
// Only create the evaluator the first time we get here | ||
if (!evaluator) | ||
evaluator = std::make_unique<FEPointEvaluation<dim,dim>>(this->get_mapping(), | ||
this->get_fe(), | ||
update_gradients, | ||
this->introspection().component_indices.velocities[0]); | ||
|
||
// Initialize the evaluator for the old velocity gradients | ||
evaluator->reinit(in.current_cell, quadrature_positions); | ||
evaluator->evaluate(solution_values, | ||
EvaluationFlags::gradients); | ||
|
||
const SymmetricTensor<2,dim> strain_rate = symmetrize (evaluator->get_gradient(i)); | ||
|
||
|
||
const double edot_ii = std::max(std::sqrt(std::max(-second_invariant(deviator(strain_rate)), 0.)), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think to avoid future confusion we should calculate both |
||
min_strain_rate); | ||
double delta_e_ii = edot_ii*this->get_timestep(); | ||
|
||
|
@@ -664,7 +689,6 @@ namespace aspect | |
// as the values from the current linearization point are an extrapolation of the solution | ||
// from the old timesteps. | ||
// Prepare the field function and extract the old solution values at the current cell. | ||
std::vector<Point<dim>> quadrature_positions(1,this->get_mapping().transform_real_to_unit_cell(in.current_cell, in.position[i])); | ||
|
||
// Use a small_vector to avoid memory allocation if possible. | ||
small_vector<double> old_solution_values(this->get_fe().dofs_per_cell); | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.