Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert subtree action back to checkout v3 #1211

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Revert subtree action back to checkout v3 #1211

merged 1 commit into from
Dec 21, 2023

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Dec 21, 2023

This PR #1200 broke our subtree split. I reverse it now to get it working.

@Nyholm Nyholm merged commit 4a8c20b into geocoder-php:master Dec 21, 2023
45 of 49 checks passed
jbelien added a commit that referenced this pull request Dec 28, 2023
@jbelien
Revert "Revert subtree action back to checkout v3 (#1211)"
983e585 
This reverts commit 4a8c20b.
@jbelien
Copy link
Member

jbelien commented Dec 28, 2023

Sorry about that, the issue was not caused by #1200 (so I've reverted it in 983e585) but by my personal token that has expired.
I've rotated the token (will expire on 1st December 2024) and updated SUBTREE_GITHUB_TOKEN secret in Geocoder PHP organization secrets.

@Nyholm
Copy link
Member Author

Nyholm commented Dec 28, 2023

Wohoo. Awesome.

Yeah. I noticed this too. Thank you for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nyholm @jbelien