Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable PHPStan Level 6 #1194

Merged
merged 23 commits into from
Jul 31, 2023
Merged

Enable PHPStan Level 6 #1194

merged 23 commits into from
Jul 31, 2023

Conversation

jbelien
Copy link
Member

@jbelien jbelien commented Jul 16, 2023 •
edited
Loading

Level 6 is "report missing typehints"
See https://phpstan.org/user-guide/rule-levels

Warning
Waiting for #1197 to be merged because we use mixed type.

@jbelien jbelien self-assigned this Jul 16, 2023
@jbelien jbelien mentioned this pull request Jul 16, 2023
Merged
@jbelien jbelien mentioned this pull request Jul 21, 2023
Merged
@jbelien jbelien requested a review from norkunas July 21, 2023 16:43
@jbelien jbelien marked this pull request as ready for review July 21, 2023 16:45
@jbelien jbelien requested a review from Nyholm July 21, 2023 16:45
@jbelien jbelien merged commit 722fc19 into master Jul 31, 2023
117 checks passed
@jbelien jbelien deleted the phpstan/level-6 branch July 31, 2023 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@norkunas norkunas Awaiting requested review from norkunas

@Nyholm Nyholm Awaiting requested review from Nyholm

Assignees

@jbelien jbelien

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbelien @norkunas