depgraph: Do not trigger rebuilds for some options #1310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not trigger rebuilds for options which do not merge packages like --buildpkgonly, --fetchonly, and --fetch-all-uri. Bug: https://bugs.gentoo.org/927301 Signed-off-by: Zac Medico <[email protected]>
|
Still happens with the patch applied on top of 3.0.63. |
Though the conditions seem to work. I guess some other code needs to be disabled as well. |
zmedico
commented
Mar 20, 2024
| if self._dynamic_config._allow_backtracking: | ||
| if self._dynamic_config._allow_backtracking and not any( | ||
| opt in self._frozen_config.myopts for opt in _NO_MERGE_OPTS | ||
| ): | ||
| self._slot_operator_trigger_reinstalls() |
There was a problem hiding this comment.
It seems like --buildpkgonly needs to be in a class of its own here, since --fetch* should behave mostly like regular build commands in order to avoid prevent discrepancies in behavior (like the slot conflicts in https://bugs.gentoo.org/161422 though those would exist without --fetchonly you get the idea).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not trigger rebuilds for options which do not merge packages like --buildpkgonly, --fetchonly, and --fetch-all-uri.
Bug: https://bugs.gentoo.org/927301