easy install functions.sh but not consoletype, for x86-winnt profiles #5
Conversation
headers.h
Outdated
| #if defined(__GLIBC__) | ||
| #if defined(__GLIBC__) || defined(__CYGWIN__) | ||
| # define HAVE_UNISTD_H | ||
| # define HAVE_SYS_IOCTL_H |
There was a problem hiding this comment.
This breaks compilation with musl libc. According to the main code, the include should be conditional on __linux__ instead of __GLIBC__.
headers.h
Outdated
| # define HAVE_SYS_SYSMACROS_H | ||
| # define HAVE_ERROR_H | ||
| # define HAVE_TTYNAME |
There was a problem hiding this comment.
unistd.h and ttyname should be available on any POSIX system. So it seems that it would make more sense to test for systems without them.
| #ifdef HAVE_SYS_SYSMACROS_H | ||
| # include <sys/sysmacros.h> | ||
| #endif | ||
|
|
||
| #if defined(__GNUC_STDC_INLINE__) && (__GNUC_STDC_INLINE__ - 0) |
There was a problem hiding this comment.
No Clang anywhere here: It should "work", but may not inline anything eventually.
There was a problem hiding this comment.
@grobian AFAIR, you're using Clang: Do you know whether it does accept the #if (__GNUC_STDC_INLINE__ - 0) preprocessor construct?
There was a problem hiding this comment.
% echo "#if defined(__GNUC_STDC_INLINE__) && (__GNUC_STDC_INLINE__ - 0)\n#error yes\n#endif" | clang -E -
# 1 "<stdin>"
# 1 "<built-in>" 1
# 1 "<built-in>" 3
# 340 "<built-in>" 3
# 1 "<command line>" 1
# 1 "<built-in>" 2
# 1 "<stdin>" 2
<stdin>:2:2: error: yes
#error yes
^
1 error generated.
So I guess yes?
headers.h
Outdated
| #if defined(__GLIBC__) | ||
| #if defined(__GLIBC__) || defined(__CYGWIN__) | ||
| # define HAVE_UNISTD_H | ||
| # define HAVE_SYS_IOCTL_H | ||
| # define HAVE_SYS_SYSMACROS_H | ||
| # define HAVE_ERROR_H |
There was a problem hiding this comment.
In a tangential direction: It seems that the <error.h> header isn't used at all.
Although consoletype can be built with MSVC, it is of less use there.
|
I just wanted to report that now everything works fine with musl. Thanks! |
No description provided.