Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switched mesh-ui search sort from creation date to relevancy score #332

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

fmteixeira
Copy link

Relates to #331
When searching in the mesh-ui, the results are ordered by the creation date instead of the relevancy score, this creates the following problems:

  • The most relevant nodes are not at the top of the search result list (example displayed on the image below)
  • When there's more than 10 results found, only the first 10 are shown as there's no pagination
  • The lack of pagination and ordering by creation date opens the possibility to bury the most relevant nodes on inaccessible pages

Image of a search where the most relevant is not at the top

It seems that this is affected by the code on the images below, I suggest removing the "sort" parameters from these queries as it will use the relevancy by default.
Code 1 at "src\app\core\providers\effects\list-effects.service.ts" line 189
Code 2 at "src\app\core\providers\effects\list-effects.service.ts" line 232

@CLAassistant
Copy link

CLAassistant commented Sep 10, 2020

CLA assistant check
All committers have signed the CLA.

@Jotschi
Copy link
Contributor

Jotschi commented Nov 30, 2020

Thanks for the PR. We have unfortunately no resources to review the PR at the moment. I'll let you know when / if this changes.

@Jotschi Jotschi removed the request for review from philippguertler November 30, 2020 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants