Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Chasca #2316

Draft
wants to merge 26 commits into
base: main
Choose a base branch
from
Draft

Implement Chasca #2316

wants to merge 26 commits into from
+1,972 −5

Conversation

Charlie-Zheng
Copy link
Contributor

@Charlie-Zheng Charlie-Zheng commented Jan 25, 2025 •
edited
Loading

  • New character package
  • Config in character package
  • Run pipeline with added config (generates character curve, talent stats, .generated.json files)
  • Character key
  • Shortcuts for character key
  • Update mode-gcsim.js with shortcuts for syntax highlighting
  • Add Character package to imports
  • Normal Attack
  • Charge Attack / Aimed Shot
  • Skill
  • Burst
  • A1
  • A4
  • C1
  • C2
  • C3
  • C4
  • C5
  • C6
  • Other necessary talents (custom dash/jump, low/high plunge, ...)
  • Hitlag
  • ICD
  • StrikeType
  • PoiseDMG (blunt attacks only for now)
  • Hitboxes
  • Attack durability
  • Particles
  • Frames
  • Update documentation
  • Xingqiu/Yelan N0 (optional)
  • Xianyun Plunge (optional)

@Charlie-Zheng Charlie-Zheng marked this pull request as draft January 25, 2025 20:09
@Charlie-Zheng
Merge remote-tracking branch 'origin/main' into chasca-dev
7ccce66 
# Conflicts:
#	pkg/shortcut/characters.go
#	ui/packages/components/src/Editor/mode-gcsim.js
#	ui/packages/ui/src/util/mode-gcsim.js
@Charlie-Zheng
Copy link
Contributor Author

Currently, the implementation allows for the user to put in the config

chasca skill, aim[bullets=6]:4, aim[bullets=5], low_plunge;

Even though she will only fire 4 bullets on the last aim.

Is this acceptable?
Instead I can add a check to make the next action an error when Chasca cannot fire the requested number of bullets (but the default aim will be allowed to fire off however many are possible)

@imring imring added the area: internal Related to artifacts/weapons/characters label Jan 30, 2025
@imring imring added the kind: game alignment Missing mechanic from the game label Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area: internal Related to artifacts/weapons/characters kind: game alignment Missing mechanic from the game
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Charlie-Zheng @imring