call add without 2nd argument (recursive) (#4)

genkgo · Jun 11, 2024 · e6bafc7 · e6bafc7
1 parent ca37c60
commit e6bafc7
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/src/lib.rs b/src/lib.rs
@@ -51,7 +51,7 @@ pub fn get_module() -> Module {
         Ok::<_, phper::Error>(())
     })
         .argument(Argument::by_val("path"))
-        .argument(Argument::by_val("recursive"));
+        .argument(Argument::by_val_optional("recursive"));
 
     watcher.add_method("watch", Visibility::Public, |this, arguments| {
         let handler = arguments.get_mut(0).unwrap();

diff --git a/tests/php/recommended_watcher.php b/tests/php/recommended_watcher.php
@@ -5,6 +5,7 @@
 error_reporting(E_ALL);
 
 $watcher = new FsNotify\RecommendedWatcher();
+$watcher->add(__DIR__);
 $watcher->add(__DIR__, recursive: false);
 $watcher->watch(function (FsNotify\Event $event) {
     var_dump($event->getKind());