Add Redis Storage Add On #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cadgerfeast
reviewed
Mar 11, 2024
packages/@mollitia/redis-storage/test/unit/module/ratelimit.spec.ts
Outdated
Show resolved
Hide resolved
packages/@mollitia/redis-storage/test/unit/module/ratelimit.spec.ts
Outdated
Show resolved
Hide resolved
cadgerfeast
reviewed
Apr 15, 2024
cadgerfeast
reviewed
Apr 15, 2024
cadgerfeast
approved these changes
Apr 17, 2024
cadgerfeast
reviewed
Apr 30, 2024
.github/workflows/redis_test.yml
Outdated
| - name: Install net tools | ||
| run: | | ||
| sudo apt-get update | ||
| #sudo apt-get install -y redis-tools redis-server |
There was a problem hiding this comment.
I guess we can remove this one if not used
There was a problem hiding this comment.
Adjusted as I want to be able to test both options (redis install via aptget and redis install via gha)
Comment on lines
11
to
12
| npm install redis --save | ||
| npm install @mollitia/redis --save |
There was a problem hiding this comment.
I think it's ok to do that inline: npm install @mollitia/redis redis --save
.github/scripts/redis_test/index.js
Outdated
| await success(circuit2, { data: 'Circuit2', delay: 150 }); | ||
| check(slidingTimeBreaker2.state === Mollitia.BreakerState.OPENED, 'Ok, circuit is opened', 'Circuit is not opened as expected...'); | ||
| await delay(10); | ||
| await expect(circuit.fn(successAsync).execute('dummy')).resolves.toEqual('dummy'); |
There was a problem hiding this comment.
Are those expects coming from vitest?
It doesn't look like it's a vitest test file
There was a problem hiding this comment.
Right, forgot to replace these ones.
Fixed
cadgerfeast
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.