Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ambiguous relation for "is_small_mol_activator" #33

Closed
dustine32 opened this issue Feb 15, 2024 · 6 comments
Closed

Ambiguous relation for "is_small_mol_activator" #33

dustine32 opened this issue Feb 15, 2024 · 6 comments
Assignees
Labels
bug Something isn't working high priority requires immediate attention

Comments

@dustine32
Copy link

In this GO-CAM (DLG4 Alliance), there is an edge (circled) that's not in the legend so it's unclear what the edge means:
image
Looking in the Editor, I can see this edge relation is "is small molecule activator of":
image

Note: "is_small_mol_activator" is NOT a descendant of positively_regulates in RO

@dustine32
Copy link
Author

Reported by Paul Sternberg. Commented on by @thomaspd.

Tagging @tmushayahama @kltm @vanaukenk @cmungall @pkalita-lbl

@kltm
Copy link
Member

kltm commented Feb 15, 2024

@pgaudet This was brought up in email; assigned to the "Alliance" project for the moment, but there may be a better home for it.

@dustine32
Copy link
Author

From @thomaspd on a 2024-03-04 call: Query production models for all used relations (or causal relations only?) and ensure the pathway widget knows how to render them correctly.

@vanaukenk
Copy link

See #50

@vanaukenk vanaukenk added the high priority requires immediate attention label Nov 20, 2024
@vanaukenk
Copy link

vanaukenk commented Nov 21, 2024

'is small molecule activator of' display the same line, color, and symbol as direct positive regulation
'is small molecule inhibitor of' display the same line, color, and symbol as direct negative regulation

Don't display the 'has small molecule activator' or 'has small molecule inhibitor' relations - these models will need to be flagged and updated.

Spreadsheet

@vanaukenk
Copy link

Tested on noctua-dev and appears to be working okay with the new symbols and legends.

@vanaukenk vanaukenk moved this from In Progress to Ready for Noctua production in Pathway Viewer improvements and bug fixes Jan 7, 2025
@vanaukenk vanaukenk moved this from Ready for Noctua production to Done in Pathway Viewer improvements and bug fixes Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high priority requires immediate attention
Development

No branches or pull requests

4 participants