Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/update extension cardinality stufe 2 #477

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

f-peverali
Copy link
Contributor

@f-peverali f-peverali commented Nov 6, 2024

Contributor Pull Request

Description

change of cardinality in extension

Motivation and Context

backport aus Stufe 3 analogous #464

How has this been tested?

Snippets or Screenshots (if necessary):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this IG / specification.
  • My change requires a change to the documentation or narrative (intend) of the IG.
  • I have already updated the documentation / narrative (intend) accordingly.

Reviewer / Quality Assurance Checklist

  • The Present PR does not need a thorough review process, due to brevity, low complexity or because it represents a rather minor change; otherwise go trough the list! ... and read the linked manual, if you did not do it yet!

content review steps (based on Best Practice IG Germany)

formal intellectual review steps of Implementation Guide

  • no formal review needed

  • proofreading for orthography

  • there are no (critical) validation Errors in the CI pipeline

    • inspected and no critical errors found(In the "github action view" -> Option button -> "View raw logs") - possibly list non-critical below
  • skim reading for correct rendering of IG (possibly using IG-grep of string String like "Could not render")

automated review steps:

  • no formal review needed
  • check IG-pages for broken links (possibly using plug-in)
  • [ ]

For reviewers

You migh use this: https://conventionalcomments.org/

@f-peverali f-peverali changed the base branch from main-isik-stufe-4 to TC_2.0.8 November 6, 2024 12:33
@f-peverali f-peverali merged commit 78a6bd9 into TC_2.0.8 Nov 6, 2024
@f-peverali f-peverali deleted the feature/update-extension-cardinality-stufe-2 branch November 6, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants