-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Several updates to the liquefaction module #8982
Conversation
Congratulations for the hard work, I see nothing stopping the merge of the PR now :-) About the question Check if it makes sense to refactor sep/classes.py and sep/liquefaction/liquefaction.py to adopt a structure similar to the hazardlib/gsim module, with a base.py providing the abstract base class and each liquefaction model going into its own file I would keep the code as it is. I don't see a strong reason to go in the same direction as hazardlib, certainly not for the moment. |
This pull request:
To do before merging: