Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several updates to the liquefaction module #8982

Merged
merged 205 commits into from
Oct 2, 2023
Merged

Conversation

LanaTodorovic93
Copy link
Contributor

@LanaTodorovic93 LanaTodorovic93 commented Sep 4, 2023

This pull request:

To do before merging:

  • Add scikit-learn as a dependency, which is required by TodorovicSilva2022NonParametric (@vot4anto)
  • Add onnxruntime as a dependency. Remove scikit-learn, as pickle is not required anymore. (@vot4anto)
  • Complete documentation of the newly added models (@LanaTodorovic93)
  • Add rock-slope failure analysis (extended by @LanaTodorovic93)
  • Add corresponding tests (@LanaTodorovic93)
  • Tutorials (@LanaTodorovic93)
  • Add a scenario liquefaction demo (@LanaTodorovic93)
  • Add a stochastic event-based liquefaction demo (@LanaTodorovic93)
  • Check if keeping test_sep_suite_1.py makes sense, given that currently, all tests in this suite are skipped and now that all site parameters are expected to be input through a CSV file rather than as rasters (@cossatot). Removed by @LanaTodorovic93
  • Update the changelog once the PR is approved.
  • (Optional, can go into a future PR) Check if it makes sense to refactor sep/classes.py and sep/liquefaction/liquefaction.py to adopt a structure similar to the hazardlib/gsim module, with a base.py providing the abstract base class and each liquefaction model going into its own file (@micheles)

raoanirudh and others added 30 commits August 29, 2023 11:30
- Include year of model in class name and function name
- Replace zhu_magnitude_correction_factor by idriss_magnitude_weighting_factor
- Formatting
@LanaTodorovic93 LanaTodorovic93 removed the request for review from cossatot September 28, 2023 06:16
@micheles
Copy link
Contributor

micheles commented Oct 2, 2023

Congratulations for the hard work, I see nothing stopping the merge of the PR now :-)

About the question Check if it makes sense to refactor sep/classes.py and sep/liquefaction/liquefaction.py to adopt a structure similar to the hazardlib/gsim module, with a base.py providing the abstract base class and each liquefaction model going into its own file I would keep the code as it is. I don't see a strong reason to go in the same direction as hazardlib, certainly not for the moment.

@raoanirudh raoanirudh merged commit 7b2df8d into master Oct 2, 2023
5 checks passed
@raoanirudh raoanirudh deleted the todorovic-liquefaction branch October 2, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants