Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an action to run the whole set of tests on Windows #8924

Merged
merged 88 commits into from
Aug 31, 2023

Conversation

ptormene
Copy link
Member

@ptormene ptormene commented Jul 26, 2023

The intention is to run this before any release, to highlight if there are any problems in addition to the usual approximation differences.

NOTE: the current action "Windows test of OpenQuake Engine", that is supposed to run all demos, actually only runs ClassicalDamage (see https://github.com/gem/oq-engine/actions/runs/5662246331/job/15341827073)

Also fixes #8963

@ptormene ptormene added this to the Engine 3.18.0 milestone Jul 26, 2023
@ptormene ptormene requested a review from vot4anto July 26, 2023 14:08
@ptormene ptormene self-assigned this Jul 26, 2023
@ptormene ptormene changed the title Add an action to run the whole set of tests on Windows Draft: Add an action to run the whole set of tests on Windows Jul 27, 2023
@ptormene ptormene changed the title Draft: Add an action to run the whole set of tests on Windows Add an action to run the whole set of tests on Windows Jul 27, 2023
@ptormene ptormene marked this pull request as draft July 27, 2023 07:11
@micheles
Copy link
Contributor

micheles commented Aug 30, 2023

We should add a test forbidding CSV files without CRLR to enter the repo (the CSV files are normally submitted by third parties, not by us). Possibly in another PR.

@ptormene ptormene marked this pull request as ready for review August 31, 2023 08:18
Copy link
Contributor

@vot4anto vot4anto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ptormene ptormene merged commit 3eead59 into master Aug 31, 2023
5 checks passed
@ptormene ptormene deleted the windows-all-tests branch August 31, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong path separator on Windows when removing a calculation through the WebUI
3 participants