-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an action to run the whole set of tests on Windows #8924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptormene
changed the title
Add an action to run the whole set of tests on Windows
Draft: Add an action to run the whole set of tests on Windows
Jul 27, 2023
ptormene
changed the title
Draft: Add an action to run the whole set of tests on Windows
Add an action to run the whole set of tests on Windows
Jul 27, 2023
… same output in all operating systems
micheles
approved these changes
Aug 30, 2023
We should add a test forbidding CSV files without CRLR to enter the repo (the CSV files are normally submitted by third parties, not by us). Possibly in another PR. |
…his branch" This reverts commit 7906a63.
vot4anto
approved these changes
Aug 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intention is to run this before any release, to highlight if there are any problems in addition to the usual approximation differences.
NOTE: the current action "Windows test of OpenQuake Engine", that is supposed to run all demos, actually only runs ClassicalDamage (see https://github.com/gem/oq-engine/actions/runs/5662246331/job/15341827073)
Also fixes #8963