Adding with_betw_ratio in Aristotle mode
#10127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raoanirudh
reviewed
Nov 11, 2024
| expo_hdf5, oq.mosaic_model, | ||
| oq.tectonic_region_type.encode('utf8')) | ||
| # add with_betw_ratio when only the total stddev is defined | ||
| betw = {'with_betw_ratio': 1.7} |
There was a problem hiding this comment.
I think we should try to avoid the hardcoding of the value for this parameter, especially because the ratio might be different for different tectonic region types. Can we surface this through the interface in some way so that the engine doesn't make an implicit decision on behalf of the user?
There was a problem hiding this comment.
It is already done, since in the job.ini file it is possible to specify the parameter with_betw_ratio to any value (see #10128). The value 1.7 was chosen for consistency with GEESE. However, we do not have a WebUI interface to change the parameter. If you want that, I guess for the advanced interface i.e. for GEM people and not for Aristotle users, you should open a ticket.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing errors like