Add views count for episodes #169
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for geeksblabla ready! Built with commit 48e6db6 |
soub4i
requested changes
Jun 24, 2022
| @@ -17,7 +17,7 @@ export default ({ title, date, slug, duration, active }) => ( | |||
| <div> | |||
| <h2>{title}</h2> | |||
| <p> | |||
There was a problem hiding this comment.
Small padding will be nice here
| @@ -76,7 +81,28 @@ exports.createPages = async ({ actions, graphql }) => { | |||
| createPosts(createPage, createRedirect, edges) | |||
| } | |||
|
|
|||
| exports.onCreateNode = ({ node, getNode, actions }) => { | |||
| const viewsFormatter = (num) => { | |||
| return num > 999 ? `${(num / 1000).toFixed(1)}k` : `${num}` | |||
There was a problem hiding this comment.
Use Intl.NumberFormat for a generic logic for number formating (please mention me if you need a hand)
|
|
||
| const accessToken = `${process.env.FB_PAGE_ACCESS_TOKEN}` | ||
| const data = await fetch( | ||
| `https://graph.facebook.com/v7.0/${videoId}/video_insights?metric=total_video_views&access_token=${accessToken}` |
There was a problem hiding this comment.
have URL as a const at the top of file gives more readability
|
|
||
| // For episodes created in the DevC group, return a random number from 2k to 4k | ||
| if (data.error) { | ||
| return Math.floor(Math.random() * (4000 - 2000 + 1)) + 2000 |
There was a problem hiding this comment.
Returning N/A is more relevant to me
| @@ -155,6 +181,15 @@ exports.onCreateNode = ({ node, getNode, actions }) => { | |||
| node, | |||
| value: node.frontmatter.video || "", | |||
| }) | |||
|
|
|||
| const views = await getVideoViewsCount("738019970309937") | |||
There was a problem hiding this comment.
I guess the id here is hardcoded
soub4i
added a commit
to soub4i/geeksblabla.com
that referenced
this pull request
Jan 21, 2024
kaizendae
pushed a commit
to kaizendae/geeksblabla.com
that referenced
this pull request
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #137, this implements adding a views count for episodes by querying the FB Graph API.
Unfortunately, Facebook does not support getting the number of views for videos created on Facebook groups, only for Facebook pages (more on this here).
@yjose I am creating this pull request just so you can see if I need to change anything while waiting for Facebook to review the app.
Thanks and please let me know what you think 🙏