Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attachment cannot be instantiated #17

Merged
merged 3 commits into from
Jan 12, 2017
Merged

Attachment cannot be instantiated #17

merged 3 commits into from
Jan 12, 2017

Conversation

navyad
Copy link
Contributor

@navyad navyad commented Aug 19, 2016

solution 2 for Issue #16

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 91.16% when pulling 6d8b75a on navyad:navyad/patch-2 into 591d68e on geeknam:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 91.892% when pulling 9157ffb on navyad:navyad/patch-2 into 591d68e on geeknam:master.

@geeknam
Copy link
Owner

geeknam commented Aug 28, 2016

@navyad Hey, a unit test for this would be appreciated ;)

@coveralls
Copy link

Coverage Status

Coverage increased (+1.2%) to 92.754% when pulling 751aeef on navyad:navyad/patch-2 into 591d68e on geeknam:master.

@navyad
Copy link
Contributor Author

navyad commented Aug 29, 2016

@geeknam i have added the unit tests.

@geeknam geeknam merged commit 56c8715 into geeknam:master Jan 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geeknam geeknam geeknam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@navyad @coveralls @geeknam