Explicitly initialize eerepr #2183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
|
Thanks, @aazuspan! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @giswqs and team. I'm planning to update
eereprin the near future (aazuspan/eerepr#39) to require explicit initialization for attaching the repr methods instead of initializing on import. In other words, HTML reprs will only be available onceeerepr.initializeis explicitly called.This PR would allow
geemapto continue automatically initializingeereprafter that release. This is backwards compatible since the initialize function was already available in past releases. The only downside will be a couple redundantsetattrcalls on import.Happy to discuss further, especially if there are any concerns about synchronizing the release or downstream impacts on Earth Engine documentation (I don't foresee any).