try the next host on connnect_timeout #619
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@larskanis any feedback? |
larskanis
force-pushed
the
try-next-host-on-timeout
branch
from
616c6f9 to
fe4b41c
Compare
|
Thank very much you for this PR! Somehow I had the opinion, that this is already implemented. But it is not! I'll try to add some useful tests for it and will probably add an error message that mentions multiple host connection attempts, like libpq does in blocking mode: $ psql "host=11.11.11.11,22.22.22.22 connect_timeout=5"
psql: error: connection to server at "11.11.11.11", port 5432 failed: timeout expired
connection to server at "22.22.22.22", port 5432 failed: timeout expired |
libpq does not support connect_timeout when using the async api. So when using the async connection API with a multi-host connection string libpq will not timeout connections to the first host in the list and thus will not attempt to connect to any subsequent hosts in the connection string list. This fixes this by closing and reopenning the connection with a reordered connection string when connection times out. See discussion on the pgsql-hackers list discussing this "feature" of the api: https://www.postgresql.org/message-id/flat/CA%2Bmi_8YyGKA9dWELu63e%3DKL2oN-%2BFe4uca4EtFfb6uQD4Up8pw%40mail.gmail.com
in case of several hosts and async API. This is what libpq does in sync API as well.
larskanis
force-pushed
the
try-next-host-on-timeout
branch
from
fe4b41c to
b0b0d9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #618
libpq does not support connect_timeout when using the async api.
So when using the async connection API with a multi-host connection string libpq will never timeout connections to the first host in the list and will not try try subsequent hosts in the connection string list.
This fixes this by closing and reopenning the connection with a reordered connection string if the connection to a host times out.
See discussion on the pgsql-hackers list discussing this "feature" of the api: https://www.postgresql.org/message-id/flat/CA%2Bmi_8YyGKA9dWELu63e%3DKL2oN-%2BFe4uca4EtFfb6uQD4Up8pw%40mail.gmail.com