Heuristics tests are altered to panic with multiple results #4252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runtime/vara/src/tests.rs
Outdated
| pub parachain_read_heuristic: CostOf<GearPagesAmount>, | ||
| } | ||
|
|
||
| impl<T: pallet_gear::Config> From<MemoryWeights<T>> for PagesCosts { |
There was a problem hiding this comment.
btw we already have gear_core::costs::LazyPagesCosts. mb reuse it here?
gear/pallets/gear/src/schedule.rs
Line 1304 in 73929e3
There was a problem hiding this comment.
we could add the missing fields (from MemoryWeights<T>) to gear_core::costs::LazyPagesCosts and reuse that for both gtest and these checks.
There was a problem hiding this comment.
That way LazyPagesCosts become not actually costs of lazy pages. wdyt @grishasobol ?
There was a problem hiding this comment.
Do you think we need a more generic name for the structure? @breathx
breathx
reviewed
Nov 4, 2024
…-improve-ux-of-runtime-heuristics-tests
…-improve-ux-of-runtime-heuristics-tests
Lazark0x
added
A0-pleasereview
breathx
approved these changes
Nov 5, 2024
…-improve-ux-of-runtime-heuristics-tests
breathx
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4246